xela.codes/NinjaIOUtils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

config changes for automute mod #113

Merged
kasdk21k2 merged 4 commits from master into master 2025-11-21 03:42:32 -05:00
Conversation 5 Commits 4 Files changed 4 +62 -80
kasdk21k2 commented 2025-06-16 15:39:50 -04:00 (Migrated from github.com)
Copy link
No description provided.
itzTheMeow (Migrated from github.com) reviewed 2025-06-16 15:39:50 -04:00
itzTheMeow (Migrated from github.com) requested changes 2025-06-16 21:07:19 -04:00
itzTheMeow (Migrated from github.com) left a comment
Copy link

This, additionally review my comments on discord.

This, additionally review my comments [on discord](https://discord.com/channels/468176956232302603/670362292659159040/1384337475237056522).
userscript/src/api/Settings.ts
itzTheMeow (Migrated from github.com) commented 2025-06-16 21:06:42 -04:00
Copy link

We shouldn't be modifying localStorage from inside a mod.
Use the config property.

We shouldn't be modifying localStorage from inside a mod. Use the config property.
kasdk21k2 (Migrated from github.com) reviewed 2025-06-16 22:03:35 -04:00
userscript/src/api/Settings.ts
kasdk21k2 (Migrated from github.com) commented 2025-06-16 22:03:35 -04:00
Copy link

is it "from inside a mod"?

is it "from inside a mod"?
itzTheMeow (Migrated from github.com) reviewed 2025-06-16 22:49:12 -04:00
userscript/src/api/Settings.ts
itzTheMeow (Migrated from github.com) commented 2025-06-16 22:49:12 -04:00
Copy link

nvm im dumb and didnt read properly

nvm im dumb and didnt read properly
itzTheMeow commented 2025-11-21 03:42:26 -05:00 (Migrated from github.com)
Copy link

probably fine

probably fine
Sign in to join this conversation.
Reviewers
No reviewers
itzTheMeow
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
xela.codes/NinjaIOUtils!113
No description provided.