hi #111

Merged
kasdk21k2 merged 4 commits from new2 into master 2025-04-26 00:21:11 -04:00
kasdk21k2 commented 2025-04-17 09:51:00 -04:00 (Migrated from github.com)

changes for mute mod. replaced deprecated pixi stuff in hookModMenu. noguests option didnt work - fixed, but now without log in ninja chat.

p.s, in hookModMenu, first item of the scroll:
top = Math.round((mods.length - this.maxMods) * this.scrollTop);
edited to
top = Math.max(0, Math.round((mods.length - this.maxMods) * this.scrollTop));

because sometimes when there's only 2 mods installed, it returned -1, prob

changes for mute mod. replaced deprecated pixi stuff in hookModMenu. noguests option didnt work - fixed, but now without log in ninja chat. p.s, in hookModMenu, first item of the scroll: top = Math.round((mods.length - this.maxMods) * this.scrollTop); edited to top = Math.max(0, Math.round((mods.length - this.maxMods) * this.scrollTop)); because sometimes when there's only 2 mods installed, it returned -1, prob
itzTheMeow (Migrated from github.com) requested changes 2025-04-19 12:24:21 -04:00
itzTheMeow (Migrated from github.com) left a comment

LGTM otherwise.
Still have yet to test the script.

LGTM otherwise. Still have yet to test the script.
@ -76,13 +87,20 @@ export class AutoMuteMod extends Mod<{
case "doNotMuteGuests":
itzTheMeow (Migrated from github.com) commented 2025-04-19 12:19:27 -04:00

These should use the NinjaEvents.

These should use the NinjaEvents.
@ -157,22 +192,31 @@ export class AutoMuteMod extends Mod<{
}
itzTheMeow (Migrated from github.com) commented 2025-04-19 12:20:08 -04:00

again, use NinjaEvents

again, use NinjaEvents
kasdk21k2 commented 2025-04-22 13:35:54 -04:00 (Migrated from github.com)

unfortunately cant rebuild and test the script anytime soon.

unfortunately cant rebuild and test the script anytime soon.
itzTheMeow commented 2025-04-26 00:21:05 -04:00 (Migrated from github.com)

looks fine to me

looks fine to me
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
xela.codes/NinjaIOUtils!111
No description provided.