xela.codes/NinjaIOUtils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

optimizing config load for mods, no guests mod option, fix of typing issues #109

Merged
kasdk21k2 merged 5 commits from new into master 2025-04-14 14:03:41 -04:00
Conversation 5 Commits 5 Files changed 8 +218 -108
kasdk21k2 commented 2025-04-12 04:49:45 -04:00 (Migrated from github.com)
Copy link
No description provided.
itzTheMeow commented 2025-04-14 00:44:12 -04:00 (Migrated from github.com)
Copy link

Thanks for this, i'll review it when i get the chance.

Thanks for this, i'll review it when i get the chance.
itzTheMeow (Migrated from github.com) reviewed 2025-04-14 13:49:55 -04:00
userscript/src/mods/autoMute.ts
@ -120,20 +114,14 @@ export class AutoMuteMod extends Mod<{
}
}
itzTheMeow (Migrated from github.com) commented 2025-04-14 13:49:53 -04:00
Copy link

I'll type these as "any" for now, but they should have their own typing in the future.

I'll type these as "any" for now, but they should have their own typing in the future.
itzTheMeow (Migrated from github.com) approved these changes 2025-04-14 14:02:59 -04:00
itzTheMeow (Migrated from github.com) left a comment
Copy link

Other than those two things, LGTM and I'll merge.

Also keep in mind there are still some deprecated PIXI v7 features being used in the hookModMenu.

Other than those two things, LGTM and I'll merge. Also keep in mind there are still some deprecated PIXI v7 features being used in the hookModMenu.
kasdk21k2 commented 2025-04-15 00:23:10 -04:00 (Migrated from github.com)
Copy link

huh wanted to draft it to add somehting else. anyway thanks lol

huh wanted to draft it to add somehting else. anyway thanks lol
itzTheMeow commented 2025-04-15 00:31:34 -04:00 (Migrated from github.com)
Copy link

GitHub has draft PRs for that purpose.

GitHub has draft PRs for that purpose.
Sign in to join this conversation.
Reviewers
No reviewers
itzTheMeow
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
xela.codes/NinjaIOUtils!109
No description provided.