xela.codes/NinjaIOUtils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

added auto mute mod, changes in mods config UI #107

Merged
kasdk21k2 merged 15 commits from auto-mute into master 2025-03-28 23:26:06 -04:00
Conversation 12 Commits 15 Files changed 7 +659 -24
kasdk21k2 commented 2025-03-18 01:26:00 -04:00 (Migrated from github.com)
Copy link
No description provided.
itzTheMeow (Migrated from github.com) reviewed 2025-03-18 01:26:00 -04:00
itzTheMeow (Migrated from github.com) requested changes 2025-03-25 14:52:42 -04:00
itzTheMeow (Migrated from github.com) left a comment
Copy link

I haven't actually tested the script yet, I'll have to do that after your comments/changes.

I haven't actually tested the script yet, I'll have to do that after your comments/changes.
userscript/NinjaIOUtils.js
itzTheMeow (Migrated from github.com) commented 2025-03-23 19:56:01 -04:00
Copy link

again, pnpm

again, pnpm
userscript/src/hookModMenu.ts
itzTheMeow (Migrated from github.com) commented 2025-03-25 14:48:28 -04:00
Copy link

Is there a reason for these cosmetic changes?

Is there a reason for these cosmetic changes?
userscript/src/hookModMenu.ts
@ -308,7 +308,6 @@ export default function hookModMenu() {
// no idea why these values work the way they do
itzTheMeow (Migrated from github.com) commented 2025-03-25 14:48:41 -04:00
Copy link

can just remove this log, i forgot to when i was testing

can just remove this log, i forgot to when i was testing
userscript/src/hookModMenu.ts
itzTheMeow (Migrated from github.com) commented 2025-03-25 14:48:53 -04:00
Copy link

?

?
userscript/src/hookModMenu.ts
itzTheMeow (Migrated from github.com) commented 2025-03-25 14:49:27 -04:00
Copy link

why not convert this to a string?

why not convert this to a string?
userscript/src/lib.d.ts
@ -159,6 +159,21 @@ declare module "lib" {
}
itzTheMeow (Migrated from github.com) commented 2025-03-25 14:50:12 -04:00
Copy link

are these PIXI Containers? if so they should be typed as such rather than any

are these PIXI Containers? if so they should be typed as such rather than `any`
userscript/src/mods/autoMute.ts
@ -0,0 +174,4 @@
this.originalDisplayChatBubble = Label.prototype.displayChatBubble;
}
if (Ninja.isGuest()) {
this.log("Not supported for guests.", config.Colors.red);
itzTheMeow (Migrated from github.com) commented 2025-03-25 14:52:04 -04:00
Copy link

Is this required? The userscript already officially does not support guest users so this seems redundant.

Is this required? The userscript already officially does not support guest users so this seems redundant.
itzTheMeow commented 2025-03-25 14:53:10 -04:00 (Migrated from github.com)
Copy link

Sorry for taking so long, I was sick the past few days and been catching up on schoolwork.

Sorry for taking so long, I was sick the past few days and been catching up on schoolwork.
❤️ 1
kasdk21k2 (Migrated from github.com) reviewed 2025-03-26 06:52:25 -04:00
userscript/src/hookModMenu.ts
kasdk21k2 (Migrated from github.com) commented 2025-03-26 06:52:25 -04:00
Copy link

old one made my mod description go off the container

old one made my mod description go off the container
kasdk21k2 (Migrated from github.com) reviewed 2025-03-26 06:52:35 -04:00
userscript/src/hookModMenu.ts
kasdk21k2 (Migrated from github.com) commented 2025-03-26 06:52:35 -04:00
Copy link

cosmetic

cosmetic
kasdk21k2 (Migrated from github.com) reviewed 2025-03-26 06:53:38 -04:00
userscript/src/hookModMenu.ts
kasdk21k2 (Migrated from github.com) commented 2025-03-26 06:53:38 -04:00
Copy link

i had a problem with it, dont remember why. now i checked and its ok, i returned old line

i had a problem with it, dont remember why. now i checked and its ok, i returned old line
kasdk21k2 (Migrated from github.com) reviewed 2025-03-26 06:54:15 -04:00
userscript/src/lib.d.ts
@ -159,6 +159,21 @@ declare module "lib" {
}
kasdk21k2 (Migrated from github.com) commented 2025-03-26 06:54:15 -04:00
Copy link

from game.js:

class PlayerDropdown extends PIXI.Container {
...
this.muteRow = new PlayerDropdownActionRow("Mute",PlayerDropdown.Action.MUTE,15597568);
this.unmuteRow = new PlayerDropdownActionRow("Unmute",PlayerDropdown.Action.UNMUTE,15597568);
this.inviteRow = new PlayerDropdownActionRow("Send friend invitation",PlayerDropdown.Action.INVITE,16763904);
...}

...

class PlayerDropdownActionRow extends PIXI.Container {
constructor(a, b, c) {...}
...}

from game.js: class PlayerDropdown extends PIXI.Container { ... this.muteRow = new PlayerDropdownActionRow("Mute",PlayerDropdown.Action.MUTE,15597568); this.unmuteRow = new PlayerDropdownActionRow("Unmute",PlayerDropdown.Action.UNMUTE,15597568); this.inviteRow = new PlayerDropdownActionRow("Send friend invitation",PlayerDropdown.Action.INVITE,16763904); ...} ... class PlayerDropdownActionRow extends PIXI.Container { constructor(a, b, c) {...} ...}
kasdk21k2 (Migrated from github.com) reviewed 2025-03-26 06:57:41 -04:00
userscript/src/mods/autoMute.ts
@ -0,0 +174,4 @@
this.originalDisplayChatBubble = Label.prototype.displayChatBubble;
}
if (Ninja.isGuest()) {
this.log("Not supported for guests.", config.Colors.red);
kasdk21k2 (Migrated from github.com) commented 2025-03-26 06:57:41 -04:00
Copy link

currently for guests only alert is shown, all the features work.
i wanted it so this mod wont load if logged on guest

currently for guests only alert is shown, all the features work. i wanted it so this mod wont load if logged on guest
itzTheMeow (Migrated from github.com) reviewed 2025-03-26 13:34:39 -04:00
userscript/src/mods/autoMute.ts
@ -0,0 +174,4 @@
this.originalDisplayChatBubble = Label.prototype.displayChatBubble;
}
if (Ninja.isGuest()) {
this.log("Not supported for guests.", config.Colors.red);
itzTheMeow (Migrated from github.com) commented 2025-03-26 13:34:39 -04:00
Copy link

can probably just remove this then. utils already shows the user an alert if they are a guest
image

can probably just remove this then. utils already shows the user an alert if they are a guest ![image](https://github.com/user-attachments/assets/f129740e-bada-409f-8aa5-c197b724d693)
itzTheMeow (Migrated from github.com) requested changes 2025-03-26 13:51:33 -04:00
itzTheMeow (Migrated from github.com) left a comment
Copy link

Buiz recently upgraded the site to the latest PIXI v8. Most of the old methods still work, however new code should use the v8 syntax since we will have to migrate the entire script at one point.
Migration Guide: https://pixijs.com/8.x/guides/migrations/v8#breaking-changes

This text should have a black stroke.
image
The label text should probably be migrated to use an existing FontStyle and you can extend it with the cloneTextStyle function to change its size. (maybe use the same text style the Checkbox component uses)

Buiz recently upgraded the site to the latest PIXI v8. Most of the old methods still work, however new code should use the v8 syntax since we will have to migrate the entire script at one point. Migration Guide: https://pixijs.com/8.x/guides/migrations/v8#breaking-changes This text should have a black stroke. ![image](https://github.com/user-attachments/assets/64152175-2216-49aa-a817-cfe1b1978f62) The label text should probably be migrated to use an existing `FontStyle` and you can extend it with the `cloneTextStyle` function to change its size. (maybe use the same text style the Checkbox component uses)
itzTheMeow commented 2025-03-26 13:55:43 -04:00 (Migrated from github.com)
Copy link

These buttons overlap a little.
image
If i remove a player from the list, the scrollbar resets to the top and theres a gap at the bottom.
image

These buttons overlap a little. ![image](https://github.com/user-attachments/assets/cd962f21-5bae-45b1-8bae-b02ba41fc7f8) If i remove a player from the list, the scrollbar resets to the top and theres a gap at the bottom. ![image](https://github.com/user-attachments/assets/cf1feeac-98cb-45b3-8b50-2dea49852849)
kasdk21k2 commented 2025-03-26 22:35:47 -04:00 (Migrated from github.com)
Copy link

I dont see Delete buttons overlapping.
About guests: yes, there's alert, but it doesnt restrict anything, all the mods load and work. I want this mod to not load if logged on guest, I would like to leave it as it is

I dont see Delete buttons overlapping. About guests: yes, there's alert, but it doesnt restrict anything, all the mods load and work. I want this mod to not load if logged on guest, I would like to leave it as it is
Sign in to join this conversation.
Reviewers
No reviewers
itzTheMeow
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
xela.codes/NinjaIOUtils!107
No description provided.